Repository navigation
Host: harden input admission across every target argument - #255
Merged
Merged
Conversation
Admission now resolves every argument that names a target window (snapshot, to_snapshot, a notification id's snapshot) and an explicit pid, checks each against the own-UI and System Settings rules, and refuses a pid or target.pid that disagrees with the snapshot's. Why: native2/Sources/DesktopHost/Admission.swift | admission must check every snapshot dispatch can act on (snapshot, to_snapshot, the notification id's prefix); add any new snapshot-carrying argument to targetProcesses Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening for the host's input admission.
snapshot,to_snapshot, the snapshot in adesktop_notification_actionid) plus any explicitpid/target.pid, and runs the own-UI and System Settings checks on each.pidortarget.pidthat disagrees with the call'ssnapshotis refused (invalidRequest), since dispatch acts on the snapshot.AdmissionTargetTestscalls admission with each argument shape.swift test --package-path native2passes (all suites).🤖 Generated with Claude Code