Repository navigation
fix(desktop): open a notification's channel when it's clicked, and summarize a run before it asks - #694
Open
iamnbutler wants to merge 3 commits into
Open
fix(desktop): open a notification's channel when it's clicked, and summarize a run before it asks#694iamnbutler wants to merge 3 commits into
iamnbutler wants to merge 3 commits into
Conversation
…mmarize a run before it asks Why: apps/desktop/native/notify.m | Ace posts its own UNUserNotificationCenter notifications with the channel in userInfo; Electrobun's showNotification has no click handling Why: packages/channel/src/room.ts#function section | the rolling summary is updated before the agent asks a question, so the Dashboard row describes what waits on the person
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not merged. The native notification click still needs to be seen on a Mac.
Clicking a desktop notification now opens its channel.
Utils.showNotificationfrom Electrobun 1.18.1 has no click handling, so the desktop app posts notifications itself throughUNUserNotificationCenter(native/notify.m, built intoace-notify.dylib). Each notification carries its channel's id inuserInfo. A click activates Ace, then sendsace:channelto the last-used window, or opens a window at#channel=<id>when none is open. The page selects that channel once it's listed. Mention notices carry their channel, and so does a batch of missed mentions when it covers one channel. A team join ask carries no channel and just opens Ace.The channel prompt now asks the agent to update the rolling summary before it asks a question, as well as before its final answer. That way the Dashboard row describes the run that's waiting, not the earlier answered one.
Map: ^578, ^577.
Smoke test (a desktop dev build from this lane,
ACE_PORT=5164, its own profile):anthropic/claude-opus-5-5to read README.md and then ask a question. While the question waited,ace infogave the summary as "…choose between adding a LICENSE file or a .gitignore; waiting on the user's choice."#channel=<notify-b>opened notify-b, even though notify-a had a waiting question (the no-project jump would otherwise go there). Sendingace:channelwith notify-a's id switched the view to notify-a.Built in Ace
No. Claude Code (a fix-train worker) wrote this from the shell, a desktop dev build and headless Playwright, not in an Ace channel (#5).