Repository navigation
Conversation
I think there are no CI workflows, so I checked the box. |
| @@ -0,0 +1,12 @@ | |||
| # Referred to https://github.com/supabase/supabase/blob/8547b6f2335c5b8d534eaa223fdffdd7cd041714/.gitignore | |||
There was a problem hiding this comment.
📝
I linked to .gitignore of the commit I referred to.
There was a problem hiding this comment.
This was helpful for the review but I think it should be removed from here before merging. We don't often include references like these in our templates 👍
|
This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open. |
|
reopen |
|
This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open. |
dooleydevin
left a comment
dooleydevin
left a comment
There was a problem hiding this comment.
I have a concern about including the .env files. Can you provide documentation on them?
|
|
||
| # Include template .env file for docker-compose | ||
| !docker/supabase/.env | ||
| !docker/supabase-traefik/.env |
There was a problem hiding this comment.
I'm nervous about this change. It's pretty common to include secrets in .env files. Can you include documentation for these or remove them?
Reasons for making this change
I think Supabase is a popular service.
But there was no
.gitignorefor Supabase, so I added it.Links to documentation supporting these rule changes
https://github.com/supabase/supabase/blob/master/.gitignore
If this is a new template
Link to application or project’s homepage: https://supabase.com/
Merge and Approval Steps