Repository navigation
Assembly.gitignore - #4745
Assembly.gitignore#4745NwolisaVincent wants to merge 2 commits into
Conversation
|
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
|
Thank you for letting me know what is going on. |
|
This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open. |
dooleydevin
left a comment
dooleydevin
left a comment
There was a problem hiding this comment.
I have some surface-level suggestions, but ultimately I think we'll need more documentation than what is here to justify pulling in this whole template in its current form.
I'd ask that you provide external documentation/justification on the different sections here, and comment-out sections that might accidentally ignore legitimate paths.
For example, it looks like there are over 16 million results for files under the path build/ on GitHub. That might be a good section to comment out with a note that they are usually used for build output and should likely be ignored.
| *.HEX | ||
| *.app | ||
| *.axf | ||
| *.elf |
| # IDE and assembler-specific project files | ||
| *.workspace | ||
| *.uvproj* | ||
| *.uvopt* | ||
| *.uvgui* | ||
| *.cproj | ||
| *.atsln | ||
| *.atsuo |
There was a problem hiding this comment.
We specifically discourage editor-specific ignore rules, asking that they are reserved for the /Global templates. I'd ask that you remove these.
| # CMake | ||
| CMakeCache.txt | ||
| CMakeFiles/ | ||
| cmake_install.cmake |
There was a problem hiding this comment.
CMake has a separate template already that is much more in-depth. I'd recommend it at the top of the template rather than duplicate it here 👍 https://github.com/github/gitignore/blob/9402f6ab0fb9dbbc6be7958f75ff43d7a83f92ca/CMake.gitignore
| # Build directories | ||
| build/ | ||
| Build/ | ||
| BUILD/ | ||
| bin/ | ||
| Bin/ | ||
| BIN/ | ||
| obj/ | ||
| Obj/ | ||
| OBJ/ | ||
| out/ | ||
| output/ | ||
| Output/ | ||
| dist/ | ||
| release/ | ||
| debug/ | ||
| Debug/ | ||
| Release/ |
There was a problem hiding this comment.
I'd consider simplifying some of these with character classes, like
[Bb]uild
to match both build and Build 👍
Reasons for making this change
To allow users to make use of the Assembly .gitignore file