Repository navigation
Node: Add react-router - #4729
deniz-blue wants to merge 1 commit into
Conversation
|
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
|
pending yes/no |
|
This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open. |
dooleydevin
left a comment
There was a problem hiding this comment.
Appreciate the contribution! I think commenting out the build/ rule is the right approach.
My only ask for this is that we explain the usage of the build folder and why it might be ignored in a comment as well, since it conflicts somewhat with line 38 where we ignore only build/Release 👍
|
This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open. |
Reasons for making this change
react-router is a widely used library/framework for making routing based react applications. this PR adds react-router v7 framework mode's gitignore folders
Links to documentation supporting these rule changes
React router has added framework mode on v7 which is based on Vite.
React router documentation unfortunately does not mention both of these:
.react-routerfolder houses autogenerated.tsfiles (per-route) for type checkingbuildfolder (as opposed todistwith vite)I have added
.react-routerinto the gitignore but I am unsure about including thebuildfolder. Should I keep it like this, include it or remove it? Currently its commented out (so if anyone needs to, they can uncomment it)Merge and Approval Steps