Skip to content

Node: Add react-router - #4729

Open
deniz-blue wants to merge 1 commit into
github:mainfrom
deniz-blue:main
Open

deniz-blue wants to merge 1 commit into
github:mainfrom
deniz-blue:main

Conversation

@deniz-blue

Copy link
Copy Markdown

Reasons for making this change

react-router is a widely used library/framework for making routing based react applications. this PR adds react-router v7 framework mode's gitignore folders

Links to documentation supporting these rule changes

React router has added framework mode on v7 which is based on Vite.

React router documentation unfortunately does not mention both of these:

  • .react-router folder houses autogenerated .ts files (per-route) for type checking
  • React router puts build output into the build folder (as opposed to dist with vite)

I have added .react-router into the gitignore but I am unsure about including the build folder. Should I keep it like this, include it or remove it? Currently its commented out (so if anyone needs to, they can uncomment it)

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

@deniz-blue
deniz-blue requested a review from a team as a code owner September 11, 2025 15:11
@github-actions

Copy link
Copy Markdown

This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄

@github-actions github-actions Bot added the stale label Dec 10, 2025
@deniz-blue

Copy link
Copy Markdown
Author

pending yes/no

@github-actions github-actions Bot removed the stale label Dec 11, 2025
@github-actions

Copy link
Copy Markdown

This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open.

@github-actions github-actions Bot added the stale label Mar 11, 2026

@dooleydevin dooleydevin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution! I think commenting out the build/ rule is the right approach.

My only ask for this is that we explain the usage of the build folder and why it might be ignored in a comment as well, since it conflicts somewhat with line 38 where we ignore only build/Release 👍

@github-actions

Copy link
Copy Markdown

This PR is stale because there have been no updates in 90 days. It will close after 365 days of inactivity. Leave a comment if you want to keep it open.

@github-actions github-actions Bot added the stale label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants