Skip to content

fix(build): Inline DEBUG_BUILD at each use so esbuild drops debug code - #26324

Draft
logaretm wants to merge 1 commit into
developfrom
awad/esbuild-debug-build-dce
Draft

fix(build): Inline DEBUG_BUILD at each use so esbuild drops debug code#26324
logaretm wants to merge 1 commit into
developfrom
awad/esbuild-debug-build-dce

Conversation

@logaretm

@logaretm logaretm commented Nov 12, 2026

Copy link
Copy Markdown
Member

esbuild kept debug-only code under __SENTRY_DEBUG__: false because it inlines the imported DEBUG_BUILD too late, fixed by inlining the flag at every use site in the npm build.

I added an esbuild size-limit entry with __SENTRY_DEBUG__: false so we notice if this regresses.

closes #26140

@github-actions

github-actions Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 23b669a (PR test merge using develop at 73e928a)

Against: 73e928a (develop) · base run #65941

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.12 kB +0.3% +88 B 🔺
@sentry/browser - with treeshaking flags 28.23 kB +0.01% +2 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 28.14 kB +0.05% +13 B 🔺
@sentry/browser (incl. Tracing) 52.4 kB +0.39% +200 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.4 kB +0.37% +193 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.47 kB +0.54% +296 B 🔺
@sentry/browser (incl. Tracing, Replay) 93.02 kB +0.31% +284 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.52 kB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.36 kB +0.29% +279 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.77 kB +0.24% +255 B 🔺
@sentry/browser (incl. Feedback) 47.76 kB +0.2% +95 B 🔺
@sentry/browser (incl. sendFeedback) 30.7 kB +0.28% +83 B 🔺
@sentry/browser (incl. FeedbackAsync) 35.72 kB +0.29% +101 B 🔺
@sentry/browser (incl. Metrics) 31.45 kB +0.3% +92 B 🔺
@sentry/browser (incl. Logs) 31.72 kB +0.26% +82 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.41 kB +0.34% +109 B 🔺
@sentry/react 32.14 kB +0.31% +98 B 🔺
@sentry/react (incl. Tracing) 55.04 kB +0.34% +182 B 🔺
@sentry/vue 38.34 kB +0.34% +128 B 🔺
@sentry/vue (incl. Tracing) 55.35 kB +0.37% +203 B 🔺
@sentry/svelte 30.14 kB +0.31% +92 B 🔺
@sentry/remix (Remix 3 client bundle) 58.15 kB +0.33% +188 B 🔺
CDN Bundle 31.79 kB - -
CDN Bundle (incl. Tracing) 52.58 kB - -
CDN Bundle (incl. Logs, Metrics) 34.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.14 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.61 kB - -
CDN Bundle (incl. Tracing, Replay) 90.63 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.6 kB - -
CDN Bundle - uncompressed 92.69 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.13 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.03 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 162.76 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.11 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.27 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.9 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 294.69 kB - -
@sentry/nextjs (client) 58.47 kB +0.4% +232 B 🔺
@sentry/sveltekit (client) 53.48 kB +0.42% +223 B 🔺
@sentry/core/server 44.61 kB +0.18% +76 B 🔺
@sentry/core/browser 14.05 kB +0.44% +61 B 🔺
@sentry/node 149.77 kB +0.19% +280 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB -0.01% -3 B 🔽
@sentry/node - without tracing 88.68 kB +0.33% +283 B 🔺
@sentry/node - without channel injection 138.73 kB +0.21% +282 B 🔺
@sentry/aws-serverless 97.64 kB +0.34% +329 B 🔺
@sentry/cloudflare (withSentry) - minified 209.25 kB +2.4% +4.9 kB 🔺
@sentry/cloudflare (withSentry) 479.48 kB +1.09% +5.16 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 235.01 kB +2.34% +5.35 kB 🔺
@sentry/browser (incl. Tracing) - esbuild with treeshaking flags 52.12 kB added added

View base workflow run

@github-actions

github-actions Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 4 not successful, 55 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E node-eve Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) Failing after 10m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 47s Details
✅ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 33s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (latest) Test (optional) Successful in 50s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 46s Details
✅ CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 4m Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 32s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (bun) Test (optional) Successful in 50s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 43s Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (cloudflare) Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 56s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 58s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 39s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 41s Details
✅ CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (deno) Test (optional) Successful in 55s Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 57s Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 53s Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 39s Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 37s Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 30s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 37s Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 58s Details

@logaretm
fix(build): Inline DEBUG_BUILD at each use so esbuild drops debug code
8aaff5b 
esbuild inlines an imported constant only after its dead-code pass, so
guards on the imported `DEBUG_BUILD` survived `__SENTRY_DEBUG__: false`.
The npm build now drops the import and defines `DEBUG_BUILD` as the flag
expression at every use site.
@logaretm
logaretm force-pushed the awad/esbuild-debug-build-dce branch from 48706b1 to 8aaff5b Compare November 13, 2026 09:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Debug-only code survives esbuild DCE (early-return guard)

1 participant

@logaretm