ShellCheck report #1

Activity

1. devdrops

   added

   enhancement

   on Apr 11, 2016
2. devdrops commented on May 2, 2016

   

   devdrops

   on May 2, 2016

   OwnerAuthor

   More actions

   Also check https://github.com/koalaman/shellcheck/wiki to understand each point 😉.
3. devdrops commented on Sep 9, 2016

   

   devdrops

   on Sep 9, 2016

   Last edited by devdrops

   OwnerAuthor

   More actions

   Update:

   In pre-commit line 40:
   CONFIG_FILE=$(dirname $0)/config
                         ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 41:
   if [ -e $CONFIG_FILE ]; then
           ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 42:
       . $CONFIG_FILE
       ^-- SC1090: Can't follow non-constant source. Use a directive to specify location.
         ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 129:
       SNIFFS=""
       ^-- SC2034: SNIFFS appears unused. Verify it or export it.
   
   
   In pre-commit line 185:
       ID=$(git diff-index --cached $against $FILE | cut -d " " -f4)
                                             ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 190:
       mkdir -p "$TMP_STAGING/$(dirname $FILE)"
                                        ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 191:
       git cat-file blob $ID > "$TMP_STAGING/$FILE"
                         ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 202:
       PHPCS_OUTPUT=$($PHPCS_BIN -s $IGNORE_WARNINGS $PHPCS_CODING_STANDARD $ENCODING $IGNORE $STAGED_FILES)
                                                                                              ^-- SC2086: Double quote to prevent globbing and word splitting.
   
   
   In pre-commit line 227:
       PHPMD_OUTPUT=$($PHPMD_BIN $STAGED_FILES $PHPMD_OUTPUT $PHPMD_PATTERNS_LIST $PHPMD_SUFFIXES_LIST $PHPMD_EXCLUDE_LIST)
                                 ^-- SC2086: Double quote to prevent globbing and word splitting.