Repository navigation
Fix review findings: reliable failed-report retries, Windows 11, sign… - #3
Merged
Merged
Conversation
…ing (2.1.0) Failed reports - Save exception text with control characters exactly (XML character references), keep \r\n, replace lone surrogates; write atomically (temp file + rename). - Queue per application (%TEMP%\CrashReporterNET\<app>) with unique timestamp+GUID file names. - Persist the full snapshot (title, versions, developer/user message, screenshot choice, crash time) and resend it unchanged on retry, without recapturing a screenshot; DrDump retries report the saved application title/version. - Add RetryFailedReportsAsync(CancellationToken): runs entirely on the thread pool; one retry per application at a time (exclusive queue lock, also across processes); DeliveryTimeout per report; cancellation interrupts SMTP delivery on .NET Framework (SendAsyncCancel). - Delete a delivered report before optionally opening the browser. Doctor Dump - Share HttpClient instances (per proxy; pooled connection lifetime on .NET 10). - Reject non-success HTTP statuses, report SOAP faults with their reason, reject missing/nil results. - Replace characters that are invalid in XML before sending. - Do not send an anonymous report from the dialog when AnalyzeWithDoctorDump is false. - Tolerate missing network when computing the anonymous machine ID and always restore the thread culture. Other - Show Windows 11 (build >= 22000 workstation) in local reports. - Embed the screenshot in reports saved from the dialog (ravibpatel#40). - Always strong-name sign with a committed key (sn.exe generated). - Add xUnit test project (net10.0-windows + net48) and run it in CI. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing (2.1.0)
Failed reports
Doctor Dump
Other