Repository navigation
Fix #15197 FP uninitMemberVarNoCtor for class without constructor that has a member of a type without default constructor - #9013
Open
autoantwort wants to merge 1 commit into
Conversation
…t has a member of a type without default constructor Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac: https://trac.cppcheck.net/ticket/15197
Follow-up to #15080: a class without constructors that has a member whose type has no default constructor cannot be default-initialized. Every instance initializes all members, so
uninitMemberVarNoCtoris a false positive:Cause:
CheckClass::constructors()marks a class without constructors as not default-constructible only for reference members and const members of non-class type.Fix: also mark it for a (non-pointer) member whose class type has constructors but none callable without arguments. A deleted default constructor doesn't count. A variadic constructor counts as default constructor if only the parameter pack or ellipsis is left.
Limitations (still reported as before):
std::reference_wrapper(std.cfg has no such information)decltype(...))This PR was created by Claude Code (an AI coding agent) on behalf of @autoantwort.
🤖 Generated with Claude Code