You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(file): accept absolute paths and show the server's reason for missing source - #69
Follow-up to #68: these review fixes were finished locally but not pushed before #68 merged.
Changes
Absolute paths: with an auto-detected repository, codacy file /abs/path/to/repo/src/a.ts is resolved against the git root (shell completion and editors pass absolute paths). A local path that ends up outside the repository (../../x.ts, /etc/passwd) is refused before any request.
Source-unavailable reason:Source not available (…) now shows the server's message via errorReason(err), not the generated client's static status name (e.g. Payload Too Large).
Changeset: the file command is unreleased, so the existing file-command.md changeset is extended rather than adding a separate patch.
Tests
+2 tests in file.test.ts (absolute path, outside-repo refusal) and the source-error test updated to the server's reason. tsc --noEmit clean, 854/854 passing.
…sing source
- Resolve an absolute path against the git root when the repository is
auto-detected; refuse a path outside the repository before any request.
- "Source not available (...)" now shows the server's message via
errorReason() instead of the client's static status name.
- These were review-round-2 fixes left uncommitted when #68 merged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
👀 Worth a closer look
Two medium-severity portability issues remain in path validation: cross-drive paths may bypass the outside-repository check on Windows, and symlinked paths inside the repository may be rejected. These do not indicate a general acceptance-criteria gap, but they warrant review for cross-platform correctness.
Test suggestions
Resolve an absolute path inside the Git repository to a repository-relative path.
Reject relative and absolute paths outside the detected repository.
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
An absolute path through a symlink to the repository is rejected even when it names a file inside the repository. Consider resolving symlink aliases before comparing the path with the git root.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
On Windows, an absolute path on another drive is not rejected as outside the repository because path.relative returns an absolute path rather than ../.... Consider rejecting an absolute joined result as well.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Follow-up to #68: these review fixes were finished locally but not pushed before #68 merged.
Changes
codacy file /abs/path/to/repo/src/a.tsis resolved against the git root (shell completion and editors pass absolute paths). A local path that ends up outside the repository (../../x.ts,/etc/passwd) is refused before any request.Source not available (…)now shows the server's message viaerrorReason(err), not the generated client's static status name (e.g.Payload Too Large).SPECS/commands/file.md,src/commands/AGENTS.md,SPECS/README.mdchangelog.filecommand is unreleased, so the existingfile-command.mdchangeset is extended rather than adding a separate patch.Tests
+2 tests in
file.test.ts(absolute path, outside-repo refusal) and the source-error test updated to the server's reason.tsc --noEmitclean, 854/854 passing.🤖 Generated with Claude Code