Repository navigation
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8819 +/- ##
========================================
Coverage 97.17% 97.18%
========================================
Files 323 323
Lines 16629 16641 +12
Branches 1510 1510
========================================
+ Hits 16160 16172 +12
Misses 328 328
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
heyy @leandrodamascena pls review my pr and approve it. thanks!! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8800
Summary
Changes
S3RecordModel drops lifecycleEventData and replicationEventData from S3 events. Pydantic silently discards undeclared keys, so the parser loses both fields even though S3 sends them. Added three typed models for the lifecycle and replication event data, added lifecycleEventData and replicationEventData fields to S3RecordModel, added a replication event fixture and a new replication test plus lifecycle assertions.
User experience
Before: parsing an S3 event with lifecycle or replication data silently dropped those fields, so event objects had no access to them. After: both fields are preserved on the parsed S3 record.
Verification
I ran the S3 parser tests, the full parser unit suite and the functional parser tests and they all pass, with ruff and mypy clean. Negative control: both new tests fail without the fix. This PR was prepared with the assistance of an AI coding assistant, and the verification above was done by me.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.