Repository navigation
Refactor: Collapse nested if statements into single conditions - #4377
Merged
Merged
Conversation
Merge nested `if a: if b:` blocks into `if a and b:` where the outer branch does nothing but guard the inner one. `and` short-circuits identically, so behavior is unchanged; this improves indentation.
Contributor
Author
|
Hello @Fokko and @rambleraptor please review the changes which I have done. |
Fokko
approved these changes
Nov 14, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @prabhleen2317! Verified there are no behavioral changes, all checks green. LGTM! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if a: if b:blocks intoif a and b:across four filesandshort-circuits identically to a nested guardFiles changed
pyiceberg/io/__init__.pypyiceberg/partitioning.pypyiceberg/table/metadata.pypyiceberg/table/sorting.py