Repository navigation
Row Lineage: Add metadata column support for _row_id - #4375
Merged
Merged
Conversation
Fokko
approved these changes
Nov 14, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @rambleraptor! This aligns with the spec and the Java RowIdReader.
| projected_missing_fields=projected_missing_fields, | ||
| allow_timestamp_tz_mismatch=True, | ||
| ) | ||
| if row_id_index is not None and positions is not None: |
Contributor
There was a problem hiding this comment.
Nit: positions is always set when row_id_index is not None, so the positions is not None check is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I'm continuing my work on finishing up row lineage support.
It doesn't appear that PyIceberg has built anything around metadata columns. Row lineage is made up of two fields:
_row_idand_last_updated_sequence_number, which are both deemed metadata columns by the spec.I wanted to begin adding some of the infrastructure for defining metadata columns as well as wiring up _row_id.
Are these changes tested?
Included some unit tests and a Spark integration test.
Are there any user-facing changes?