Repository navigation
Check format version rather than TableMetadataV3 type for encryption - #4368
Merged
kevinjqliu merged 1 commit intoNov 13, 2026
Merged
Conversation
Matches how the rest of the codebase gates v3 features.
xanderbailey
marked this pull request as ready for review
November 13, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #3222
Rationale for this change
Follow-up from #4328 (comment): the encryption checks used
isinstance(..., TableMetadataV3), while the rest of the codebase comparesformat_version. This switches the encryption manager and the encryption key updates toformat_version < 3.Are these changes tested?
Covered by the existing tests for encryption on pre-v3 tables.
Are there any user-facing changes?
No.