Repository navigation
Conversation
Add the manifests metadata table and its focused tests. Depends on the shared snapshot metadata scan support prerequisite. Co-authored-by: Codex <codex@openai.com>
This was referenced Nov 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1120 for shared snapshot metadata scan support. Apply that prerequisite when building this draft; merge it first, then rebase this branch onto main. Each feature patch has been verified to apply cleanly to the prerequisite.
Add
ManifestsTablethroughTable::Inspect(MetadataTableKind::kManifests). Rows expose manifest paths, content, sizes, spec/snapshot IDs, nullable data/delete file counts, and readable partition summaries.Scans use the shared snapshot task and reader APIs, retain their metadata/projection/FileIO, and support reordered or empty whole-column projections and configurable batch sizes. Partition bounds recover dropped source-column types from retained schema history, including identity/truncate transforms and numeric promotion. Partition types are cached per spec within a scan.
Extracted from #876. This patch contains this table, its registrations, and its focused tests; FilesTable and PartitionsTable are separate feature patches.
Validation with the shared-support prerequisite applied: all 79 metadata tests and C++20 compatibility passed. Pre-commit on this exact feature branch and diff checks passed. The feature-specific code and factory were compiled and linked against the independently built prerequisite.