Repository navigation
Support additional DuckDB integer types such as HUGEINT, UHUGEINT, etc - #1797
Merged
Merged
Conversation
iffyio
approved these changes
Apr 4, 2025
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @alexander-beedie!
Contributor
|
@alexander-beedie could you merge in latest main in order to fix the ci lint issue? |
alexander-beedie
force-pushed
the
duckdb-integer-types
branch
from
April 5, 2025 16:22
8945b9b to
6696bf9
Compare
alexander-beedie
force-pushed
the
duckdb-integer-types
branch
from
April 5, 2025 16:25
6696bf9 to
055e898
Compare
Contributor
Author
@iffyio: done :) |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
apache#1797) Co-authored-by: Alexander Beedie <alexander.beedie@adia.ae>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
DataTypesupport for the following integer types, with tests:HUGEINT(128bit)UHUGEINT(128bit, unsigned)UTINYINTUSMALLINTUBIGINT(ref: https://duckdb.org/docs/stable/sql/data_types/numeric.html#integer-types)
Also: standardised link text/case for database names. Was mixed between (for example)
[Postgres],[postgres],[postgresql], etc. That is now standardised to[PostgreSQL], and other DB names were similarly case-standardised (bigquery → BigQuery,clickhouse → ClickHouse, etc).Cleaned up a few other minor nits in the DataType docstrings.
Note: the
clippylint from the new Rust version is addressed by #1796; I can rebase on that once it is merged.