Repository navigation
GH-1460: Log the allocation manager inferred from the classpath instead of hardcoding log with netty - #1461
Merged
Conversation
… instead of hardcoding log with netty
raulcd
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
November 12, 2026 13:11
lidavidm
approved these changes
Nov 12, 2026
Member
|
I'll let JB decide on merge since AFAIK he's still working on 20.0.0/declared a freeze |
This was referenced Nov 13, 2026
jbonofre
added a commit
that referenced
this pull request
Nov 13, 2026
…lasspath (#1470) ## What's Changed Follow-up to #1461. When no allocation manager type is set, `CheckAllocator.check()` used to pick the factory class by searching the resource location for `memory-core`, `memory-unsafe` or `memory-netty`. It now looks up each known `DefaultAllocationManagerFactory` resource and returns the factory it actually found: - A Netty or Unsafe factory loaded from a location containing `memory-core` is no longer inferred as the memory-core test factory. - The precedence is unchanged (Unsafe before Netty), but a warning is now logged when several allocation manager types are on the classpath, with the property / environment variable to choose one. - The inference is logged once, with the `Netty` / `Unsafe` name accepted by `arrow.allocation.manager.type` and the full location: ``` INFO o.apache.arrow.memory.CheckAllocator - Allocation manager type not specified, inferred Unsafe from the classpath at file:/.../memory/memory-unsafe/target/classes/org/apache/arrow/memory/unsafe/DefaultAllocationManagerFactory.class ``` With both Unsafe and Netty on the classpath: ``` WARN o.apache.arrow.memory.CheckAllocator - Found allocation manager types [Unsafe, Netty] on the classpath, using Unsafe. Set the arrow.allocation.manager.type system property or the ARROW_ALLOCATION_MANAGER_TYPE environment variable to choose one explicitly ``` `TestCheckAllocator` covers the inference with a class loader serving resources from chosen locations. Closes #1469.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Previous log was wrong and hardcoded:
New log shows for
memory-unsafe:For netty:
Closes #1460.