Repository navigation
Conversation
Contributor
Author
|
I can't seem to figure out how to get this to build... |
Collaborator
|
Thanks for taking a look at this! FYI, upstream has had some security patches since 1.9.5, so the goal for this PR should be to update to 1.9.7 instead. My strategy for doing these upgrades is to get the diff between versions of the cmake files and make changes based off that. |
Our config header was missing some variables and defining unecessary ones. The source files were missing some definitions from SelectRegex.cmake. GIT_REGEX_PCRE2 flag is only used if linking system pcre2.
Collaborator
|
Main library builds now, CI is failing to build the test runner. Even when we get the test runner building I'd like to do a pass checking the cmake diffs, as some important configuration changes could have slipped through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to see how far I can bump libgit to see if it fixes a wired error I am getting where it says I dont have
$HOME/.gitconfigfile (which I should not need as I have a$XDG_CONFIG_HOME/git/configfile).