Repository navigation
Reduce the react stockcharts steps - #200
Merged
Merged
Conversation
julienw
force-pushed
the
split-react-stockcharts
branch
from
June 1, 2023 16:03
25a2c5f to
909517f
Compare
rniwa
approved these changes
Jun 5, 2023
flashdesignory
approved these changes
Jun 5, 2023
camillobruni
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#97
There are several goals for this patch:
I decided to reduce the amount of events sent for the "pan the chart" step, and cut down the work in the "zoom the chart" step.
Now, for the "pan the chart" step, instead of moving the mouse 1000 times, it's now 50 times.
For the "zoom in" step, instead of 50 times, it's now 15 times.
base branch from #176
deploy preview
Firefox before/after
Chrome before/after
Chrome seems to benefit more than Firefox from this change, but we think it's a more realistic workload.
In more details: Chrome benefits a lot from the changes to the "pan the chart" step, but Firefox doesn't. However both benefits similarly for the reduction of the "zoom the chart" step (about 50%). It would be great to know the result for Safari @rniwa.
What do you all think?