Skip to content

MockFileSystemWatcherFactory should throw instead of returning useless MockFileSystemWatcher #329

Closed

Description

@rkoeninger

Both overloads of MockFileSystemWatcher.WaitForChanged remain unimplemented as seen here.

Activity

  1. changed the title [-]MockFileSystemWatcher.WaitForChanged not implemented[/-] [+]MockFileSystemWatcherFactory should throw instead of returning useless MockFileSystemWatcher[/+] on Nov 27, 2018
  2. rkoeninger commented on Nov 27, 2018

    @rkoeninger
    ContributorAuthor

    It was deemed in #373 that implementing a working MockFileSystemWatcher was too complex, so I think the default MockFSWFactory should throw NotImplementedException instead of returning a MockFSW that doesn't work.

    Also, it will be necessary to allow client code to inject their own FSWFactory that they can implement their own FSW.

  3. fgreinacher commented on Nov 27, 2018

    @fgreinacher
    Contributor

    I like that idea - much better for us and for our users! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions