You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
MockFileSystemWatcherFactory should throw instead of returning useless MockFileSystemWatcher #329
changed the title [-]MockFileSystemWatcher.WaitForChanged not implemented[/-][+]MockFileSystemWatcherFactory should throw instead of returning useless MockFileSystemWatcher[/+]on Nov 27, 2018
It was deemed in #373 that implementing a working MockFileSystemWatcher was too complex, so I think the default MockFSWFactory should throw NotImplementedException instead of returning a MockFSW that doesn't work.
Also, it will be necessary to allow client code to inject their own FSWFactory that they can implement their own FSW.
Activity
[-]MockFileSystemWatcher.WaitForChanged not implemented[/-][+]MockFileSystemWatcherFactory should throw instead of returning useless MockFileSystemWatcher[/+]rkoeninger commentedon Nov 27, 2018
It was deemed in #373 that implementing a working MockFileSystemWatcher was too complex, so I think the default MockFSWFactory should throw NotImplementedException instead of returning a MockFSW that doesn't work.
Also, it will be necessary to allow client code to inject their own FSWFactory that they can implement their own FSW.
fgreinacher commentedon Nov 27, 2018
I like that idea - much better for us and for our users! Thanks!