Skip to content

Fix missing-chunk recovery with the released renderer - #1501

Open
tannerlinsley wants to merge 1 commit into
mainfrom
taren/redact-recovery-734
Open

tannerlinsley wants to merge 1 commit into
mainfrom
taren/redact-recovery-734

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Missing route chunks could trap the renderer in repeated error-boundary handling before the site could recover. Upgrade Redact from 0.1.4 to 0.2.5, which includes the upstream nested error-boundary fix in TanStack/redact#109.

Align Cloudflare Vite with Redact's supported 1.65.0 peer and Wrangler with that plugin's required version. Use Vite 8's native default minifier, because the Cloudflare plugin's ES2026 worker target is rejected by esbuild, including 0.28.2.

Related to #734. Keep the issue open for deployed verification.

AI review notes:
pnpm test passed on the aligned dependencies. Both focused recovery/Sentry tests passed, including reporting failures during the reload cooldown. Production build passed after removing the esbuild override.

In a local production preview of this candidate, removing the Blog chunk and navigating from Tenets reached the error UI with two captured missing-module errors, without the prior runaway loop. Restoring the chunk and manually reloading rendered the Blog. Exact automatic reload count and live Sentry delivery were not measured.

Against main 477d87b, total gzip across all 680 client JavaScript assets decreased from 6,572,757 to 6,455,610 bytes, a reduction of 117,147 bytes. This is total emitted JavaScript, not initial page transfer size.

Required CI and protected dependency/config review remain before merge. No production deployment has been verified.

Summary by CodeRabbit

  • Chores
    • Updated the versions of the project’s build and development tools.
    • Adjusted the production build configuration. These changes do not add or remove any user-facing features, and no changes to app functionality are described in this update.

@tannerlinsley
tannerlinsley requested a review from a team November 10, 2026 08:02
@changeset-bot

changeset-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6ec489e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​tanstack/​redact@​0.1.4 ⏵ 0.2.598 +1310080 +698 +1100
Updated@​cloudflare/​vite-plugin@​1.62.5 ⏵ 1.65.099 +110087 +198 +1100
Updatedwrangler@​4.147.0 ⏵ 4.152.098 +110092 +196 +1100

View full report

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Three development dependency versions changed. The Vite build configuration no longer sets an explicit esbuild minifier.

Changes: Build tooling

Layer / File(s) Summary
Dependency and build configuration
package.json, vite.config.ts
Updated the versions of @cloudflare/vite-plugin, @tanstack/redact, and wrangler. Removed the explicit esbuild minifier setting.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: ladybluenotes

Merge Risk: Minimal · up to 6ec48

No merge-blocking issue is identified. Normal CI and deployment verification remain appropriate.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: upgrading the renderer to fix missing-chunk recovery.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a81610b4-d37e-4109-b890-6243f81fe5df
Commits

Reviewing files that changed from the base of the PR and between 477d87b and 6ec489e.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2

  • package.json
  • vite.config.ts
Files with no reviewable changes: 1

  • vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 6ec489e Commit Preview URL

Branch Preview URL
Nov 10 2026, 08:05 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant