Repository navigation
fix: safe build for target ssr - #109
Merged
Merged
Conversation
sprusak
commented
Sep 5, 2025
sprusak
commented
Contributor
- used tsup and new mapping as in query-devtools https://github.com/TanStack/query/blob/main/packages/query-devtools/package.json
- eliminated browser only code for a server build, this makes sure projects with server side rendering can safely execute this code
sprusak
force-pushed
the
feat-start-ssr-prod-build
branch
from
September 5, 2025 13:28
cdb6ec6 to
b90a2f2
Compare
sprusak
commented
Sep 5, 2025
| entries: { | ||
| entry: 'src/index.ts', | ||
| dev_entry: true, | ||
| server_entry: true, |
Contributor
Author
There was a problem hiding this comment.
ℹ️ build for SSR, will pick up this server_entry that have client side only modules removed which makes it safe to use, and Devtols are only ever mounted on the client side
2 tasks done
Collaborator
|
I also opened this PR up as a reference to the failing issues you saw: #110 |
Collaborator
|
Feel free to add those changes and I'll approve and merge and close the other one! |
Collaborator
|
Also, run |
Contributor
Author
OK thanks, I hope its ok now. I guess might be useful to add some step in CI, that verify if changeset is added? I might create some PR |
More templates
@tanstack/devtools
@tanstack/devtools-ui
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/react-devtools
@tanstack/solid-devtools
commit: |
Collaborator
|
@sprusak not every PR requires a changeset, it depends, but might be a good idea to see if there's room for improvement! |
Merged
AlemTuzlak
pushed a commit
that referenced
this pull request
Sep 5, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @tanstack/devtools@0.6.8 ### Patch Changes - Changed package.json exports to allow safe usage in ssr environments ([#109](#109)) ## @tanstack/react-devtools@0.6.4 ### Patch Changes - Updated dependencies \[[`6447ab2`](6447ab2)]: - @tanstack/devtools@0.6.8 ## @tanstack/solid-devtools@0.6.4 ### Patch Changes - Updated dependencies \[[`6447ab2`](6447ab2)]: - @tanstack/devtools@0.6.8 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.