[Mikola Lysenko (mikolalysenko)]

Problem

Scheduled CI on main (42763778797, main @ c751724) fails every mode_migration_vlt leg:

• e2e-extended on ubuntu: vlt 0.0.0-32, 1.0.0-rc.14 and 1.2.0
• e2e-macos: vlt 1.2.0
• e2e-windows: vlt 1.0.0-rc.14 and 1.2.0

That's 6 of the 8 failing jobs in the run. The other two are test (windows-latest, *), which #2049 fixes. The same legs also failed in #2049's Windows dispatch 42772455462. These legs run only at night, so PR and merge-queue CI never catch the failure. Nightly ci-ok stays red until it's fixed.

Every leg fails the same assertion in vlt_pinned_matrix_migration_hosted_scan_keeps_agent_patched_tree (migration test 8):

  left: "vlt-lock.json pins Socket-patched packages, but socket-patch could not check 1 installed copies (node_modules is a link, or node_modules/.vlt-lock.json is missing or unreadable); run `vlt ci` to be sure the patched packages are installed."
 right: "vlt-lock.json pins Socket-patched packages; fresh checkouts install them with `vlt ci` or `vlt install --frozen-lockfile`. Note: `vlt update` re-resolves from the registry and drops these hosted patches."

Root cause

#2021 changed how the vlt warm-tree heal judges a store entry: now only vlt's hidden lock decides. Without a hidden lock, the copy is kept and reported as unchecked. This is intended, and the commit message says so.

#2021 updated the rule (c) real-vlt e2e in e2e_redirect_vlt_build.rs (vlt_pinned_matrix_hosted_heal_rule_c_no_hidden_lock) to expect advisory_undeterminable. It missed the matching case in mode_migration_vlt.rs. Test 8 deletes node_modules/.vlt-lock.json and still expected the old afterHash outcome, advisory_nothing_stale().

Fix

Test 8 now expects advisory_undeterminable(ids.len()), the same as the rule (c) test, and its doc comment is updated to match. Its other assertions are unchanged and still pass:

• the store entries are kept
• the tree stays patched

The only production behaviour involved is the one #2021 intended. No production code changes.

Proof

Local runs with real vlt (SOCKET_PATCH_VLT_E2E_REQUIRED=1, --include-ignored vlt_pinned_matrix):

• main, vlt 1.2.0: test 8 fails with the exact left/right shown above (reproduced).
• This branch, vlt 1.2.0: mode_migration_vlt passes, 14 passed, 0 failed.
• This branch, vlt 0.0.0-32: 14 passed, 0 failed.

Checks:

• rustfmt --check on the touched file is clean.
• Clippy on this test target reports only clippy::duplicate_mod. That comes from how the shared test modules are wired up, and this diff doesn't touch them. Fix Windows nightly test failures and absolute --patch-dir bound #2049 saw the same pre-existing findings with local clippy 1.93.

Where tests run

No tests were removed or moved. Test 8 still runs in the nightly mode_migration_vlt legs on all three OSes.

---

Generated by Claude Code

---

Note

Low Risk
Test-only change aligning e2e expectations with intended heal behavior; no production code touched.

Overview
Aligns migration test 8 (vlt_pinned_matrix_migration_hosted_scan_keeps_agent_patched_tree) with the post-#2021 vlt heal behavior when node_modules/.vlt-lock.json is missing: the hosted scan advisory assertion now expects advisory_undeterminable(ids.len()) instead of advisory_nothing_stale(), matching the existing rule (c) real-vlt e2e.

The test doc comment is updated to state that without a hidden lock, heal rule (c) treats store copies as unchecked and recommends vlt ci, while still asserting the agent-patched store entries are kept and the tree stays patched.

^{Reviewed by Cursor Bugbot for commit 9baa35f. Configure here.}

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

bugbot run

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 9baa35f. Configure here.}

[Mikola Lysenko (mikolalysenko)]

Labeled Ready for review by the burn-down agent.

• Head: 9baa35f45dadbb250646745f4732a2d80074bd60
• CI: 50/50 checks on this head passed or were skipped (31 success, 19 skipped).
• Bugbot: reviewed 9baa35f, no findings.
• Scope: test-only change in crates/socket-patch-cli/tests/mode_migration_vlt.rs (migration test 8 now expects the "unchecked" advisory Stop fetching patch views during hosted scans #2021 introduced). The vlt legs it fixes only run nightly, so PR CI doesn't exercise them; the PR body has the local real-vlt runs. Pairs with Fix Windows nightly test failures and absolute --patch-dir bound #2049 to turn nightly ci-ok green.

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

Final review brief

What it does: Test-only fix. #2021 made the vlt heal treat a store copy with no hidden lock (node_modules/.vlt-lock.json) as "unchecked". It updated the rule (c) e2e test but missed migration test 8, which still expected the old "nothing stale" advisory. That leaves every nightly mode_migration_vlt leg red. This PR changes test 8 to expect advisory_undeterminable(n), the same as the rule (c) test.

Risk: Low. One assertion and a doc comment in an #[ignore] real-vlt e2e test. No production code changes and CHANGELOG.md is untouched.

Look here:

• mode_migration_vlt.rs:573-591: new expectation and doc comment
• e2e_redirect_vlt_build.rs:352-360: the rule (c) test it now matches (same setup: hidden lock removed, then hosted scan)
• vlt_e2e_common/fixture.rs:46: the advisory text. It matches the "left" side of the nightly failure word for word.

Verified: I read the full diff (1 file, +5/−3) and checked that the helper is in scope through vlt_e2e_common::fixture::*. The test setup matches the rule (c) test exactly. The store-kept and tree-patched assertions are unchanged. CI: ci-ok and clippy green, 50/50 checks pass. Bugbot found no issues. I did not rerun real vlt here. The PR reports 14/14 on vlt 1.2.0 and 0.0.0-32, and the nightly legs will confirm it.

Changes I made: none.

Open questions: none. This pairs with #2049; both are needed to turn nightly ci-ok green.

Auto-merge (squash) is armed, so approving sends this straight to the merge queue.

---

Generated by Claude Code