Repository navigation
feat(fix): accept UV in --package-managers - #1709
Draft
Oskar Haarklou Veileborg (BarrensZeppelin) wants to merge 1 commit into
Draft
Oskar Haarklou Veileborg (BarrensZeppelin) wants to merge 1 commit into
Oskar Haarklou Veileborg (BarrensZeppelin) wants to merge 1 commit into
Conversation
Coana now answers uv.lock and *.py.lock files to UV, so uv projects can be included or left out by name. Without UV in this list, socket fix rejects the value before Coana sees it, and a filter that names every other Python package manager silently drops uv projects.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coana now gives uv lockfiles (
uv.lock,*.py.lock) their own--package-managersvalue,UV(SocketDev/coana-package-manager#2711). Before that change they answered to no package manager, so every filter let them through.socket fixchecks--package-managersvalues against its own copy of Coana's list, which has noUV. Sosocket fix --package-managers UVfails with "Invalid package manager" before Coana runs. Worse, a filter that names every other Python package manager (POETRY PIPENV PIP_REQUIREMENTS) would silently drop uv projects once Coana is bumped.This adds
UVto the list, fixes the stale Coana path in its doc comment, and adds a changelog entry.Merge order: Coana 15.14.2, the version pinned here, rejects
UV. This should merge together with, or after, the bump to a Coana release that includes #2711.Expected reviewer effort: Stamp