Repository navigation
fix: allow macros to recursively resolve closes #2399 - #2400
Merged
Merged
Conversation
tobymao
force-pushed
the
toby/recursive_macros
branch
from
April 5, 2024 03:01
c6769c4 to
a731eb4
Compare
Contributor
Author
|
@erindru can you test that this works for your use case? |
izeigerman
reviewed
Apr 5, 2024
georgesittas
approved these changes
Apr 5, 2024
tobymao
force-pushed
the
toby/recursive_macros
branch
from
April 5, 2024 13:48
a731eb4 to
5150dc3
Compare
tobymao
enabled auto-merge (squash)
April 5, 2024 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macro variables were not resolving additional macro references. also, we ensure conversion of sql to the right dialect when using string templates like
@sqlcc @erindru