Skip to content

refactor(build): name the javac.pack span intersection with an intersect helper - #83

Merged
Project516 merged 1 commit into
masterfrom
p516/build-web-intersect
Nov 10, 2026
Merged

Project516 merged 1 commit into
masterfrom
p516/build-web-intersect

Conversation

@Project516

Copy link
Copy Markdown
Owner

What this changes

scripts/build-web.ts found the parts of javac's reads inside the compiler modules as subtract(r, subtract(r, compiler)). An intersect(spans, within) helper now says that directly. The packs it writes are the same.

Tests

  • intersect(r, c) and subtract(r, subtract(r, c)) give the same spans for 20,000 random pairs of merged span lists.
  • pnpm typecheck passes.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 223029b0-297a-4359-8eff-8e322abe07c2
Commits

Reviewing files that changed from the base of the PR and between 2e3f15d and 3b3b3aa.

Files selected for processing: 1

  • scripts/build-web.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@project516-review-bot project516-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds an intersect helper to replace the double-subtract pattern subtract(r, subtract(r, compiler)) with the more direct intersect(r, compiler). The implementation correctly computes the intersection of two merged span lists, and the change is used only for the /lib/modules path when building javac.pack. The logic is mathematically equivalent and the tests confirm identical output for 20,000 random pairs.


review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve

@Project516
Project516 enabled auto-merge (squash) November 10, 2026 00:29
@Project516
Project516 merged commit ee2cf53 into master Nov 10, 2026
16 checks passed
@Project516
Project516 deleted the p516/build-web-intersect branch November 10, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant