Repository navigation
Fix startup assembly version loading issue in PS6 - #1349
Merged
Merged
Conversation
Member
|
Ideally we wait until one person in that thread acks... but if they don't by the end of the week lets merge this and maybe do another preview release next week? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2719.
We now await the server startup task, so that errors propagate properly to the caller.
This also fixes the underlying issue, where Omnisharp requires a higher version of the System.Collections.Immutable dependency than PowerShell provides.