[Copilot]

PR Summary

Follow-up to #2270, targeting its branch rather than main.

The review finding is reproducible: a resource-shaped call to a script-defined function is treated as a DSC declaration because command discovery uses a separate runspace. Commands inside its script block arguments are then incorrectly suppressed. Both new regression cases returned zero diagnostics before the fix instead of the two expected diagnostics.

• Recognize function declarations in enclosing script-block scopes, case-insensitively, without searching unrelated nested scopes.
• Use that information consistently for resource declarations and their same-line/following-line bodies. Do not apply implicit Get- prefix corrections to script-defined function calls; preserve explicit alias handling.
• Cover script-level and configuration-level functions, both brace layouts, unrelated scopes, and formatter behavior. Document the distinction.

Validation: .NET 8 and .NET Framework 4.6.2 builds succeeded. Alias tests: 23 passed, 2 Windows-only tests skipped on Linux. Formatter integration tests: 10 passed. Executed using PowerShell 7.4.13 and Pester 5.7.1; the configured Pester 6.0.1 package was unavailable from the accessible mirror.

PR Checklist

• PR has a meaningful title
• Summarized changes
• Change is not breaking
• All changed source files have the correct copyright header
• Added regression tests and updated documentation
• This PR is ready to merge and is not Work in Progress (opened as a draft)

[Copilot]

🟡 Changes recommended

Scoped function declarations are mishandled, causing incorrect alias rewrites and suppressed diagnostics, while repeated scope scans introduce quadratic analysis overhead.

2 open issues

• Handle scoped function declarations and visibility in analysis · New
• Index function declarations to avoid repeated AST traversal · New

What changed in this PR

This follow-up to #2270 distinguishes script-defined function calls from DSC resource declarations so alias analysis preserves function names while checking commands in their script-block arguments.

Changes:

• Adds case-insensitive function lookup in enclosing script-block scopes and reuses it in DSC classification.
• Adds regression coverage for function scope, brace layouts, unrelated scopes, and formatter behavior.
• Documents the distinction between functions, DSC resources, and implicit aliases.

File	Description
Tests/​Rules/​AvoidUsingAlias.tests.ps1	Adds function-detection and formatter regression tests.
Rules/​AvoidAlias.cs	Uses script-defined function detection in alias and DSC handling.
docs/​Rules/​AvoidUsingCmdletAliases.md	Explains function and DSC resource exclusions from implicit alias correction.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Scope handling still changes command resolution for dot-sourced private functions and incorrectly treats script/global declarations in unexecuted nested functions as visible, causing missed diagnostics and unsafe corrections.

2 open issues

• Handle dot-sourced blocks using caller scope · New
• Keep nested script/global declarations in lexical scope · New

2 resolved since last review

• Index function declarations to avoid repeated AST traversal
• Handle scoped function declarations and visibility in analysis

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Dot-sourced scope handling still misindexes declarations and incorrectly skips script-block argument scopes, causing both erroneous alias corrections and missed diagnostics.

2 open issues

• Avoid skipping scopes for script-block command arguments · New
• Index dot-sourced declarations in the effective caller scope · New

2 resolved since last review

• Keep nested script/global declarations in lexical scope
• Handle dot-sourced blocks using caller scope

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The argument-count restriction incorrectly treats parameterized dot-sourced blocks as child scopes, causing erroneous alias formatting and missed declarations in the caller’s scope.

1 open issue

• Fix scope handling for parameterized dot-sourced blocks · New

2 resolved since last review

• Index dot-sourced declarations in the effective caller scope
• Avoid skipping scopes for script-block command arguments

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Singleton subexpressions are not unwrapped, causing incorrect function-scope resolution, erroneous command rewrites, and remote-command misclassification.

1 open issue

• Unwrap singleton subexpressions when resolving command scope · New

5 resolved since last review

• Only treat literal script-block arguments as local callbacks
• Treat SSHConnection as a remote Invoke-Command target
• Traverse subexpression wrappers during callback resolution
• Include synchronous local Invoke-Command blocks in scope resolution
• Recognize the clean block in execution-order checks

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because execution-order and scope-isolation edge cases can suppress valid alias diagnostics or produce incorrect formatter replacements.

No open issues 🎉

1 resolved since last review

• Unwrap singleton subexpressions when resolving command scope

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved execution-order and scope-analysis errors cause valid function calls to be incorrectly rewritten as Get-Verb and required alias diagnostics to be suppressed.

4 open issues

• Resolve nested callback phases relative to their shared invocation · New
• Treat background pipeline blocks as isolated scopes · New
• Recognize native DSC script properties as isolated scopes · New
• Exclude declarations in statically unentered loop bodies · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Scope-boundary searches incorrectly isolate nested blocks in DSC callbacks and background pipelines, hiding enclosing local functions and causing erroneous alias rewrites.

2 open issues

• Preserve enclosing job functions in nested script blocks · New
• Limit DSC isolation to the property callback script block · New

4 resolved since last review

• Exclude declarations in statically unentered loop bodies
• Recognize native DSC script properties as isolated scopes
• Treat background pipeline blocks as isolated scopes
• Resolve nested callback phases relative to their shared invocation

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The ancestor walk incorrectly treats a nested hashtable callback as an isolated DSC resource callback, causing a false Get-Verb suggestion; it needs to stop at an intervening ScriptBlockAst and gain regression coverage.

1 open issue

• Avoid treating nested ScriptBlock callbacks as DSC resource properties · New

2 resolved since last review

• Limit DSC isolation to the property callback script block
• Preserve enclosing job functions in nested script blocks

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The scope traversal incorrectly promotes global: and script: function declarations from background jobs into the foreground scope, suppressing required diagnostics for implicit Get-Verb calls.

No open issues 🎉

1 resolved since last review

• Avoid treating nested ScriptBlock callbacks as DSC resource properties

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved scope-isolation and execution-order errors in AvoidAlias can suppress required diagnostics or incorrectly rewrite valid function calls.

4 open issues

• Handle for-loop body declarations before iterator calls · New
• Account for enclosing pipeline execution order · New
• Prevent background scopes from promoting function declarations · New
• Traverse scriptblock casts when checking job isolation · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The pipeline check incorrectly rejects function declarations that execute before later calls within the same pipeline element, causing valid calls such as Verb to be rewritten to Get-Verb.

1 open issue

• Preserve nested function declarations within the same pipeline element · New

4 resolved since last review

• Traverse scriptblock casts when checking job isolation
• Prevent background scopes from promoting function declarations
• Account for enclosing pipeline execution order
• Handle for-loop body declarations before iterator calls

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because subtle scope and execution-order interactions involving scriptblock casts, eager arguments, and background callbacks can cause incorrect alias resolution.

No open issues 🎉

1 resolved since last review

• Preserve nested function declarations within the same pipeline element

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unwrapping stops at [scriptblock] casts, causing incorrect scope and invocation classification that rewrites valid Verb calls to Get-Verb.

1 open issue

• Unwrap ScriptBlock casts during caller-scope analysis · New

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Positional binding fails to exclude parameters supplied by name, causing incorrect execution-order analysis and an erroneous rewrite of Verb to Get-Verb in mixed named/positional commands.

No open issues 🎉

1 resolved since last review

• Unwrap ScriptBlock casts during caller-scope analysis

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved callback-binding and execution-flow errors produce incorrect alias diagnostics by misclassifying positional callbacks and indexing declarations from nonexecuting iterators or discarded script blocks.

2 open issues

• Do not treat script blocks discarded by void casts as callbacks · New
• Ignore for-loop iterator declarations when the condition is constant false · New

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Named-argument binding can cause incorrect alias rewrites, while oscillating scope resolution makes diagnostics depend on unrelated function declarations.

No open issues 🎉

2 resolved since last review

• Ignore for-loop iterator declarations when the condition is constant false
• Do not treat script blocks discarded by void casts as callbacks

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved execution-order and reachability errors in AvoidAlias cause valid function calls to be rewritten and required implicit-alias diagnostics to be suppressed.

6 open issues

• Track declarations across enclosing executing invocations · New
• Exclude eagerly evaluated arguments from callback exemptions · New
• Compare callbacks only with their directly containing pipeline · New
• Respect named-block order in isolated execution blocks · New
• Order dynamicparam before begin in phase mappings · New
• Account for unreachable elseif conditions · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended...

Addressed all six review findings in d16253b. The targeted AvoidUsingAlias tests pass (140 passed).

[Copilot]

🟡 Changes recommended

AvoidAlias misjudges function visibility across pipeline callbacks and eagerly evaluated arguments, causing incorrect alias rewrites and suppressed diagnostics.

2 open issues

• Distinguish deferred callback commands from eagerly resolved pipeline commands · New
• Inspect directly invoked blocks for eager argument evaluation · New

6 resolved since last review

• Account for unreachable elseif conditions
• Order dynamicparam before begin in phase mappings
• Respect named-block order in isolated execution blocks
• Compare callbacks only with their directly containing pipeline
• Exclude eagerly evaluated arguments from callback exemptions
• Track declarations across enclosing executing invocations

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Two critical pipeline callback-ordering errors can discard visible function declarations and cause the formatter to incorrectly replace script-defined Verb calls with Get-Verb.

2 open issues

• Preserve declarations across upstream End-to-downstream Process callbacks · New
• Infer effective phases for positional ForEach-Object script blocks · New

2 resolved since last review

• Inspect directly invoked blocks for eager argument evaluation
• Distinguish deferred callback commands from eagerly resolved pipeline commands

_{Review effort: Balanced}

[Copilot]

Fixed in 36e9064. Upstream End callback output is now considered visible to downstream Process callbacks, with regression coverage.

[Copilot]

Fixed in 36e9064. Positional ForEach-Object blocks now account for the implicit Begin phase when explicit Begin/End bindings are absent, with regression coverage.