Repository navigation
Warn when a server plugin class implements no plugin type - #576
Open
Hisham-InfoGleam wants to merge 1 commit into
Open
Hisham-InfoGleam wants to merge 1 commit into
Hisham-InfoGleam wants to merge 1 commit into
Conversation
initPlugins registers a server class once for each plugin type interface it implements. A class that implements ServerPlugin but none of those interfaces was instantiated and then ignored: it was never added to serverPlugins, so start() and stop() were never called, and nothing in the log said why. Log a warning that names the plugin and the class. Which plugins are registered, started and stopped does not change. Fixes OpenIntegrationEngine#398 Assisted-by: Claude:claude-fable-5-2 Signed-off-by: Hisham Alrashdan <hisham@infogleam.com>
Hisham-InfoGleam
marked this pull request as ready for review
November 13, 2026 04:53
Hisham-InfoGleam
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
ssrowe and
tonygermano
November 13, 2026 04:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398.
A server class that implements
ServerPluginbut none of the plugin type interfaces is instantiated byinitPlugins()and then ignored. It is never started or stopped, and nothing in the log says why.This change logs a warning that names the plugin and the class. It follows the direction in the issue: the behaviour stays the same, and only the silent part is fixed. The compile-time check is left out.
Tests
ResourcePluginlogs no warning and is registered../gradlew :server:testpasses locally (851 tests).