Repository navigation
SingleResultBeforeMapTests: Assert.IsType with exactMatch false instead of IsAssignableFrom (xUnit2032) - #130
Merged
Conversation
…ad of IsAssignableFrom (xUnit2032) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
electricessence
added a commit
that referenced
this pull request
Nov 12, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SingleResultBeforeMapTests: useAssert.IsType<T>(value, exactMatch: false)instead ofAssert.IsAssignableFrom<T>(value), which the xUnit analyzers flag asxUnit2032now that the tests build for net11.0.Why
net11.0target (ODX 11 targets .NET 11: net11.0 on every package, SDK pinned to 11.0.100 #122) and theSingleResulttests (command.SingleResult().Map<T>(): the opt-out reads as behavior, then shape #127) both on master,dotnet format analyzersreports two info-levelxUnit2032notes inSingleResultBeforeMapTests.cs(lines 705 and 706). The repository gate treats every finding as a failure, so every branch merged with master would show them.What
Assert.IsAssignableFrom<IExecuteReaderAsync>(x)toAssert.IsType<IExecuteReaderAsync>(x, exactMatch: false). Same meaning (the value is, or derives from, that type); test-only; no library code or public API changes.Checks
ToTargetBlockMappedCompletionTests, target closed mid-stream) failed once in the first run. Samples: 105 of 105 checks pass. Style and analyzers: 0 findings. DocFX: 0 warnings.🤖 Generated with Claude Code