Repository navigation
fix(runtime): pump messages during HTTP imports until dev boot completes - #48
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
A dev boot imports the app graph from the dev server with blocking fetches on the UI thread. On a cold server that takes seconds and the window stops responding. In debug builds, until ns:module setDevBootComplete(true), run the fetches on a helper thread that signals an event when done, while the UI thread waits in MsgWaitForMultipleObjectsEx and dispatches messages as they arrive. setDevBootComplete is exposed on ns:module for the classic and Node-API engines.
triniwiz
force-pushed
the
fix/dev-boot-pump
branch
from
November 8, 2026 20:34
1c6b109 to
280b42d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dev boot imports the app graph from the dev server with blocking fetches on the UI thread. On a cold dev server that can take several seconds, and Windows marks the window as not responding.
In debug builds, until
@nativescript/vitesignals boot completion,esm_http::fetch_moduleandfetch_modulesrun the fetch on a helper thread:MsgWaitForMultipleObjectsEx(..., QS_ALLINPUT, MWMO_INPUTAVAILABLE)and dispatches messages as they arrive.Other changes:
ns:modulegainssetDevBootComplete(done), which@nativescript/vitealready calls once the app root is committed.__nsModuleSetDevBootComplete, registered for the classic engine, the napi engine module runner andwindows-v8.