Repository navigation
Conversation
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 13, 2026 17:00
TaylorMutch
previously approved these changes
Nov 13, 2026
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
marked this pull request as draft
November 14, 2026 00:15
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
6 tasks
This was referenced Nov 14, 2026
Collaborator
Author
|
This just got waaaaaay too complicated in the name of simplifying. We'll remove the watchers for now and put in a check to prevent adding someone who's not able to be requested for review. That's #5550 Note to future me: come back and figure out the more graceful way to have "watchers" who get notified even if they can't be requested for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub rejects review requests for non-collaborators, including requests made individually. Move their area/topic subscriptions to
WATCHERS.mdand notify them through PR comment mentions, while requesting formal reviews from collaborators. Log submitted reviewer JSON and GitHub's rejection explanation so failures are actionable.Related Issue
Closes #5539.
Verified target-repository ADMIN access; the issue has no
state:acceptedlabel.Changes
REVIEWERS.mdtoWATCHERS.md, preserving every subscription and category definition.WATCHERS.mdwith CODEOWNERS. Include watcher subscriptions in the labeling approval policy fingerprint.Release Notes
Testing
git diff --checkpass. Routing code/tests and the changed labeling test pass ty. The labeling evidence module has two existing ty errors at line 511, reproduced on its unchanged HEAD version.bobbins228,gmenher, andjgarciao, with no skipped non-collaborators. It sends no requests or comments.2000krysztofon draft fix(review): notify non-collaborators through watcher mentions #5540 returned HTTP 422 with GitHub's explicit collaborator requirement. No reviewer was added.pull-requests: writecovers PR comments; no permission increase is needed.Checklist