[flagsmithsmith]

Contributes to Flagsmith/sdk-spec#13
Contributes to Flagsmith/sdk-spec#23

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 4daf4898-45aa-4db2-bedf-2d56b21659cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codspeed]

Merging this PR will not alter performance

✅ 15 untouched benchmarks

---

_{Comparing openhands/sdk-spec-v0.8.0 (88fa258) with main (1c633a1)}

[flagsmithsmith]

Pushed 88fa258 to fix the sdk-spec / Spec v0.8.0 check. It was failing because 15 scenarios use steps the SDK did not implement: flushing events, closing with a timeout, tracking a range of events, and creating a client with local evaluation and events enabled.

SDK changes (EventProcessor), following Flagsmith/sdk-spec#23 and the v0.8.0 event_delivery and event_shutdown features:

• Each events request times out after 3 s. OkHttp's own connection retry is turned off, so every attempt is one request.
• A batch gets 3 attempts. The wait before each retry backs off from 1 s, doubling, with full jitter. Network errors, timeouts, 408, 429, 500, 502, 503 and 504 are retried.
• If the last attempt fails transiently, the batch stays in the buffer, ahead of newer events, for the next flush. The exception is a 500 on the last attempt: then the batch is dropped. Any other error status drops the batch at once.
• A 401 or 403 drops the buffer and stops event tracking.
• One batch is in flight at a time (before, it was 2). The buffer holds at most 1000 events and drops the oldest when full, kept events included.
• flushEvents() waits for the send, retries included, and never completes exceptionally.

Client: new FlagsmithClient.close(long timeout, TimeUnit unit). It sends the buffered events for at most the timeout, then cancels the request in flight and drops what is left. close() waits for one batch's worst case, 12 s.

Steps: sdk-spec/Steps.java wires the four new steps to flushEvents(), close(timeout, SECONDS), trackEvent and a client built with both withLocalEvaluation(true) and withEnableEvents(true). Local experiment exposures already worked (#251), so they only needed the client step.

Tests: EventProcessorTest now covers the retry classification, the backoff sequence, the jitter bounds, the keep/drop rule for the last attempt, stopping on 401/403, dropping the oldest kept event when the buffer is full, and close(timeout) abandoning a hung request. I rewrote the tests that assumed 2 batches in flight for 1. FlagsmithClientTest covers the new close overload.

Locally, mvn clean install passes (except EngineTest, which needs the engine-test-data submodule I did not check out) and so does the release build. The spec at v0.8.0 with core or events or local-evaluation passes all 24 scenarios.

[flagsmithsmith]

Superseded by #253, which carries this pull request's work over to the SDK spec's latest version.