[goranai]

Closes #604

-k/--kernel-size of detect-content and detect-adaptive was passed to ContentDetector unchecked, so 1, even or negative values ended in a ValueError traceback. It is now validated in CliContext and reported as click.BadParameter, as --weights and --downscale already are:

Error: Invalid value for kernel-size: Kernel size must be an odd integer >= 3.

KernelSizeValue also accepted kernel-size = 1 from a config file, contrary to its docstring, and the detector then raised. It now rejects values below 3 (except -1 = auto), and its message says ">= 3", matching the CLI help, scenedetect.cfg and the docs.

Note: on the command line -k -1 is now also rejected with a usage error. The CLI help never documented -1 for -k (only the config file does), and today -k -1 crashes with the same traceback.

Tests: test_cli_kernel_size_rejects_invalid (3 CLI cases) and test_cli_kernel_size_config_file_rejects_one (2 config cases) fail on main (5 failed) and pass with this change (5 passed). In the full suite the only failures are 2 moviepy tests that fail the same way on main because moviepy is not installed locally.

AI disclosure: prepared with Claude Code (Claude Opus 5.5) and reviewed by me.

🤖 Generated with Claude Code

[Breakthrough]

Thanks for the PR, have a few small changes to ask, but other than these LGTM.

[Breakthrough]

Can we re-use KernelSizeValue here the same way --crop uses CropValue? That would also let -k -1 mean auto, like the config file.

[goranai]

Done in 4a4b66e. -k now goes through KernelSizeValue, like --crop uses CropValue, so -k -1 means auto and a bad value gives a usage error.

[Breakthrough]

Can you add cases for -k -1 and a negative value, plus a valid size (e.g. -k 3) that should succeeds?

[goranai]

Added in 4a4b66e: -k -3 and -k -2 are rejected, and -k 3 and -k -1 succeed, for both detect-content and detect-adaptive.

[Breakthrough]

Please add a changelog entry (at the very bottom under 0.8, website/pages/changelog.md), noting that kernel-size = 1 in a config file is now going to be an error.

[goranai]

Added the changelog entry under 0.8 in 4a4b66e, noting that kernel-size = 1 in a config file is now an error.

[goranai]

All three points are done in 4a4b66e: -k goes through KernelSizeValue, the tests cover -k -3, -2, 3 and -1, and the changelog has the 0.8 entry. Could you take another look when you have time?