Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Refactor/re-organising MPI related code - #625

Merged
pramodk merged 3 commits into
masterfrom
pramodk/mpi-cleanup
Aug 31, 2021
Merged

pramodk merged 3 commits into
masterfrom
pramodk/mpi-cleanup

Conversation

@pramodk

@pramodk pramodk commented Aug 31, 2021

Copy link
Copy Markdown
Collaborator

Description

  • All MPI related code is now under coreneuron/mpi
  • Separate cmake target for mpi related code and
    include MPI headers for only these files
  • Remove unnecessary headers (and MPI include)
  • Spike output function is factored into a separate file

Preparation for #600

How to test this?

No new options/instructions.

Use certain branches for the SimulationStack CI

CI_BRANCHES:NEURON_BRANCH=master,

@pramodk
pramodk requested review from iomaganaris and olupton August 31, 2021 11:41

@olupton olupton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor question.

I guess you need to rebase on top of #623 for the CI?

Comment thread coreneuron/CMakeLists.txt Resolved
  - All MPI related code is now under coreneuron/mpi
  - Separate cmake target for mpi related code and
    include MPI headers for only these files
  - Remove unnecessary headers (and MPI include)
  - Spike output function is factored into a separate file

Preparation for #600
@pramodk
pramodk force-pushed the pramodk/mpi-cleanup branch from bc67a2a to 7442787 Compare August 31, 2021 12:55

@olupton olupton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@pramodk
pramodk merged commit 9c821d5 into master Aug 31, 2021
@pramodk
pramodk deleted the pramodk/mpi-cleanup branch August 31, 2021 15:08
pramodk added a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
  - All MPI related code is now under coreneuron/mpi
  - Separate cmake target for mpi related code and
    include MPI headers for only these files
  - Remove unnecessary headers (and MPI include)
  - Spike output function is factored into a separate file

Preparation for BlueBrain/CoreNeuron#600

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@9c821d5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants